Display message when a ratelimit is hit #708
Conversation
43f5801 to
b1c164a
Compare
|
Did you want to do something like this with palette: QtGui.QPalette = self.palette()
window_color = palette.color(QtGui.QPalette.ColorRole.Window)
is_darkmode = True if window_color.lightness() < 100 else False
if is_darkmode:
toast.applyPreset(ToastPreset.WARNING_DARK)
else:
toast.applyPreset(ToastPreset.WARNING) |
|
Using the autotag window, if you cancel when the limit is waiting, the cancel (showing other windows) doesn't trigger until the wait time is over, even if the GUI wait window is closed. |
|
I don't know of a way to fix that in python. In Go that's easy comic-hasher/cv/cv.go but I don't know how to notify a sleeping thread in python. |
It shouldn't be too much of an issue as the wait should only be a few seconds most of the time? I upped it to 60 seconds wait time for testing. |
|
It gets kind of long when you hit the 200/hour limit |
|
This might be another "not easy" but is there anyway to update the limiter if there is a time sent back by the server, i.e ( |
|
No, you'd have to basically do a whole rewrite |
|
Triggering the limiter with the issue window causes: The |
|
That should be better! |
|
Getting the issue window stuck (using 3 requests a minute) and no toast. Then after it's finished, two toasts. Video: Screencast_20250115_215716.mp4 |
|
Not sure what timer is causing that... It works much better on macos, I'll have to test some stuff on linux |
|
With the Series Window when the limiter triggers it doesn't give the Because it's in a thread, it's going to be a pain to debug? |
|
I probably have to do some bullshit with a new qobject and moveToThread |
|
@mizaki try this and see if it still hangs |
|
That seems to have sorted the fetch issue list. Triggering the limit by clicking each issue after still has the problem but I guess you'd expect that going by the fix. |
As a (not nice) workaround, make the autotag window non-closable when the toast is active and make the toast non-closable? If it's not modal, user should still be able to click cancel in the autotag window? |
|
There's actually options for canceling timers/sleep https://docs.python.org/3/library/threading.html#event-objects I need to finish cleaning up the threads/signals/slots though |
Toasts calculated the duration bar in python this is now a QPropertyAnimation Series/Issue Selection windows now use signals/slots to communicate
9864159 to
9c2a2cb
Compare
|
Trying the latest changes and getting an error when using the test in GUI talker settings: |
|
Is it possible to limit the toast to the CT window? Otherwise, if you're in another window it will pop up over the top. |
|
88f11cd doesn't seem to work :-( |
|
It seems as if autotag goes through the motions but never actually writes the tags. Also, when the manual pick window for unsure results came up and I picked and accepted: |
That's just the filelist not updating |
|
It seems the covers aren't showing in the autotag window, neither local more remote. |
I managed to get this error which seems likely cause: |
|
The being able to set the wait time didn't make it in? People are going to see |
|
If you cancel the autotag there is no summary window, is that to get around it popping up only after the limiter has run down? |
Nope, that will have to happen later
I want it obvious that it's waiting for a ratelimit, when it's a manual search or auto-identify it's every 10s
Fixed
Fixed |
No description provided.