Represent last_commit as Option<Commit>#79
Represent last_commit as Option<Commit>#79liamsi merged 1 commit intocometbft:lite_impl_simple_merkle_mergedfrom
last_commit as Option<Commit>#79Conversation
There was a problem hiding this comment.
At least a brief description that motivates the changes would be cool next time :-) (even if this a PR isn't to master). Something along the lines of:
Without these changes parsing an rpc response with an empty
last_commit(e.g. on the first block), would err.
I've tested this locally... CI still doesn't run for PRs from forks :-/
Thanks again @yihuang!
Thanks, next time, I'll write some description ;D |
No description provided.