Skip to content

impl lite::ValidatorSetLookup#68

Merged
liamsi merged 1 commit intocometbft:lite_impl_simple_merkle_mergedfrom
yihuang:impl_validator_set_lookup
Nov 13, 2019
Merged

impl lite::ValidatorSetLookup#68
liamsi merged 1 commit intocometbft:lite_impl_simple_merkle_mergedfrom
yihuang:impl_validator_set_lookup

Conversation

@yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 13, 2019

No description provided.

Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

.find(|val| val.address == val_id)
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to add a little test for this. Happy to do so after merging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in: 23042bb

@liamsi liamsi merged commit c8d17a9 into cometbft:lite_impl_simple_merkle_merged Nov 13, 2019
@liamsi liamsi mentioned this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants