impl lite::Commit for commit::SignedHeader#67
Merged
liamsi merged 1 commit intocometbft:lite_impl_simple_merkle_mergedfrom Nov 13, 2019
Merged
impl lite::Commit for commit::SignedHeader#67liamsi merged 1 commit intocometbft:lite_impl_simple_merkle_mergedfrom
liamsi merged 1 commit intocometbft:lite_impl_simple_merkle_mergedfrom
Conversation
liamsi
approved these changes
Nov 13, 2019
| //! `/commit` endpoint JSONRPC wrapper | ||
|
|
||
| use crate::{block, rpc}; | ||
| use crate::{amino_types::vote::CanonicalVote, block, lite, rpc, vote::SignedVote, Hash}; |
Contributor
There was a problem hiding this comment.
The rpc module currently does not depend on amino_types. I think, if possible, we should try to keep it that way. Even if that means introducing another type under tendermint/block (or similar).
Contributor
|
Did the suggested changes here: e1a7560 |
Contributor
Author
|
Great, thanks. |
ebuchman
reviewed
Dec 17, 2019
| let chain_id = self.header.chain_id.to_string(); | ||
| let mut votes = self.commit.precommits.clone().into_vec(); | ||
| votes | ||
| .drain(..) |
Contributor
Author
There was a problem hiding this comment.
Yeah, my fault, not familiar enough with idiomatic rust then. But I believe this code already modified by @liamsi in the final merged version ;D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
lite::Committrait on thecommit::SignedHeaderstruct. This may sound a bit confusing as there also is acommit::Commitstruct. The latter does not now about the chain-id and hence we use the SignedHeader's header to fill in the chain-ids into the votes (which implmentsSignedVote).(Description added by @liamsi)