Lite: complete test mocks and start some tests#115
Merged
ebuchman merged 7 commits intobucky/spec-reorgfrom Dec 30, 2019
Merged
Lite: complete test mocks and start some tests#115ebuchman merged 7 commits intobucky/spec-reorgfrom
ebuchman merged 7 commits intobucky/spec-reorgfrom
Conversation
f2bd282 to
ae32577
Compare
62c7bfd to
f8f9e88
Compare
Contributor
Author
|
I'm going to merge this into bucky/spec-reorg locally and just push there. avoiding squash merge while other PRs are depending on this branch oh man... |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First take at some tests for the new
verify_singlefunction, ala #113This completes an implementation of mocks for the core types for the lite module and shows how to use them for testing. Still unmocked are the
StoreandRequester.There's probably much to be improved here, including the test names and how we organize them, but this seems like a decent start.
This also surfaced some issues with error types:
voting_power_incan't detect signatures from validators not in the current validator setFor now we're just duplicating some of the mocks that are already in the
verifiertests module. Probablyverifier.rsandpublic.rswill be consolidated down toverifierin #114 and this will be deduplicated then.