Skip to content

Light Client Rust related follow up #110

@ebuchman

Description

@ebuchman

Replacement for elements of #96 more specific to Rust implementation style and architecture.

We should update the ADR with the relevant changes from here as well.

Types:

Module Structure:

Errors:

  • Error::RequestFailed should wrap underlying requester errors (Light client: bisection, store, requester #100 (comment))
  • Deduplicate the Error::InvalidSignature with ErrorKind::SignatureInvalid
  • Move to an error.rs file
  • voting_power_in can't detect signatures from validators not in the current validator set (can't detect signatures from validators not in the current validator set)
  • need two distinct errors for InsufficientVotingPower - one when it's insufficient to skip (ie. so do bisection) and one when it's insufficient to verify (ie. return error) Differentiate VotingPower errors #119

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions