Improve data retrieval process + fix multi-network logic#10
Merged
sergio-mena merged 5 commits intomainfrom Feb 1, 2023
Merged
Improve data retrieval process + fix multi-network logic#10sergio-mena merged 5 commits intomainfrom
sergio-mena merged 5 commits intomainfrom
Conversation
jmalicevic
reviewed
Feb 1, 2023
README.md
Outdated
| make retrieve-data | ||
|
|
||
| #alternatively, you can retrieve the prometheus data and the block store independently | ||
| # for the prometheus database |
Collaborator
There was a problem hiding this comment.
Suggested change
| # for the prometheus database | |
| # of the prometheus database |
Collaborator
Author
There was a problem hiding this comment.
Sorry, this was a leftover, thanks for spotting
jmalicevic
reviewed
Feb 1, 2023
| # 12. Once the execution is over, stop the network | ||
| make stop-network | ||
|
|
||
| # 13. Retrieve the data produced during the execution |
Collaborator
There was a problem hiding this comment.
I would add: "The below command retrieves both the prometheus and block store data". It is not clear from this line that this command includes the two below , only them or them and something else.
Collaborator
Author
There was a problem hiding this comment.
Good point. Adding
jmalicevic
approved these changes
Feb 1, 2023
Collaborator
jmalicevic
left a comment
There was a problem hiding this comment.
Minor comments, good otherwise.
sergio-mena
commented
Feb 1, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2