Rename the crates to cometbft*, remove deprecated crates#4
Merged
Conversation
All crates published as part of the forked cometbft-rs project will use the cometbft* naming. The tendermint-abci crate was deprecated and has a better alternative maintained elsewhere, so it is removed rather than renamed.
Bulk search-and-replace changes.
Do not continue the p2p crate as part of cometbft-rs, before the need for it is clear. Also drop the auxiliary crates whose only use was to provide functionality for, or test, tendermint-p2p.
It's build-wasm-cometbft now
Contributor
Author
|
An ICE in nightly 👀 |
Contributor
|
Does updating |
Contributor
Author
This is not |
Contributor
|
Awesome! Glad to see we can execute the code coverage workflow using the stable toolchain. We'll be able to upload the coverage results to codecov.io when we make the repo public. |
Contributor
I will file a separate PR, there were a lot of bulk changes, so I have only committed some opportunistic edits so far alongside the crate renaming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To publish the crates as part of cometbft-rs, we need to rename them.
These crates have not been actively developed and are considered deprecated, so it's better remove them at this point rather than maintain them as part of the new family:
tendermint-abcitendermint-p2ptendermint-std-exttendermint-test