Conversation
This reverts commit 0c9484c.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
sergio-mena
left a comment
There was a problem hiding this comment.
I have the impression this PR has been produced mechanically/methodically, so feel free to disregard any of my remarks if addressing them means hindering the mechanical part of it.
An exception is, I think, the one about the octal notation
| // the final directory to use for the database. | ||
| path := filepath.Join(dir, dbName) | ||
|
|
||
| if err := os.MkdirAll(path, 0o755); err != nil { |
There was a problem hiding this comment.
Are we sure about this change?
Last time I was something similar was (I think) in one of Jacob's PR's, but his change also came with a change in the library used.
There was a problem hiding this comment.
The 0o755 -> 0755 change? If so, it's just a convention automatically set by the formatter. There are 3 different formats for octal literals that mean the same thing according to the Go spec: https://go.dev/ref/spec#Integer_literals
There was a problem hiding this comment.
My current plan is to clean up the repo prior to cutting a v0.6.8 release so as to update the linter config, etc. to harmonize with what we have in the CometBFT repo.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Closes #8
This is unfortunately not a simple revert, but it reverts all of the core logic/dependency changes after the v0.6.6 release.