Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
| @@ -0,0 +1,2 @@ | |||
| - Fork tm-db and rename fork to cometbft-db | |||
| ([#7](https://github.com/cometbft/cometbft-db/issues/7)) No newline at end of file | |||
There was a problem hiding this comment.
Escape the number.
Optionally, use the PR instead of the issue number.
| ([#7](https://github.com/cometbft/cometbft-db/issues/7)) | |
| ([\#29](https://github.com/cometbft/cometbft-db/pull/29)) |
There was a problem hiding this comment.
The historical convention has always been to refer to issues. The only reason why most changelog issues have included references to PRs is because contributors haven't been very good at capturing the problems they're trying to solve in issues 🙂
For now the escaping doesn't affect the rendering.
There was a problem hiding this comment.
I prefer issues as well, since they may refer to multiple PR that sum to fix it, but I was going by the contributing guide that states "It's also acceptable for xxx to refer to the relevant issue number, but pull-request numbers are preferred. " We need to update it then.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
📖 CHANGELOG rendered