Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
jmalicevic
reviewed
Jan 12, 2023
| GOTOOLS = github.com/golangci/golangci-lint/cmd/golangci-lint | ||
| PACKAGES=$(shell go list ./...) | ||
| INCLUDE = -I=${GOPATH}/src/github.com/tendermint/tm-db -I=${GOPATH}/src -I=${GOPATH}/src/github.com/gogo/protobuf/protobuf | ||
| INCLUDE = -I=${GOPATH}/src/github.com/CometBFT/CometBFT-db -I=${GOPATH}/src -I=${GOPATH}/src/github.com/gogo/protobuf/protobuf |
Collaborator
There was a problem hiding this comment.
Lines 51-53 still contain Tendermint , is this ok?
Contributor
Author
There was a problem hiding this comment.
Thanks for picking this up! I've fixed this in #16
jmalicevic
reviewed
Jan 12, 2023
|
|
||
| grpcdb "github.com/tendermint/tm-db/remotedb/grpcdb" | ||
| protodb "github.com/tendermint/tm-db/remotedb/proto" | ||
| grpcdb "github.com/CometBFT/CometBFT-db/remotedb/grpcdb" |
Collaborator
There was a problem hiding this comment.
Line 39 and 49 refer to tmlibs?
Contributor
Author
There was a problem hiding this comment.
I think these kinds of references can be renamed in a follow-up when the docs are also updated.
jmalicevic
reviewed
Jan 12, 2023
| db "github.com/tendermint/tm-db" | ||
| protodb "github.com/tendermint/tm-db/remotedb/proto" | ||
| db "github.com/CometBFT/CometBFT-db" | ||
| protodb "github.com/CometBFT/CometBFT-db/remotedb/proto" |
Collaborator
There was a problem hiding this comment.
Line 62 refers to tendermint docs.
Contributor
Author
There was a problem hiding this comment.
Same here re: when we update the documentation references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11