backport: Fix lint failures on v0.38.x#922
Merged
thanethomson merged 1 commit intov0.38.xfrom Jun 5, 2023
Merged
Conversation
* add config for depguard for more info, see https://github.com/OpenPeeDeeP/depguard#example-configs * fix nakedret Signed-off-by: Thane Thomson <connect@thanethomson.com>
v0.38.x
mzabaluev
approved these changes
Jun 5, 2023
Contributor
mzabaluev
left a comment
There was a problem hiding this comment.
...but then, you have already approved and merged the PR with the same changes against main, so let's not diverge here.
The coding style changes look good.
Comment on lines
+45
to
+46
| depguard: | ||
| rules: |
Contributor
There was a problem hiding this comment.
Can't claim I understand the logic behind these exceptions, other than
"grab and override whatever the linter is currently complaining about"...
Contributor
Author
There was a problem hiding this comment.
Afaik depguard is just one of the linters that golangci-lint runs, and this provides explicit configuration for it. See https://github.com/OpenPeeDeeP/depguard
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #908 to
v0.38.xPR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments