Skip to content

qa: rotating node test on v0.38.x (backport #883)#885

Merged
sergio-mena merged 1 commit intov0.38.xfrom
mergify/bp/v0.38.x/pr-883
May 24, 2023
Merged

qa: rotating node test on v0.38.x (backport #883)#885
sergio-mena merged 1 commit intov0.38.xfrom
mergify/bp/v0.38.x/pr-883

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented May 24, 2023

This is an automatic backport of pull request #883 done by Mergify.
Cherry-pick of dbbf00b has failed:

On branch mergify/bp/v0.38.x/pr-883
Your branch is up to date with 'origin/v0.38.x'.

You are currently cherry-picking commit dbbf00b7e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   docs/qa/img37/rotating/rotating_avg_memory.png
	new file:   docs/qa/img37/rotating/rotating_block_rate.png
	new file:   docs/qa/img37/rotating/rotating_cpu.png
	new file:   docs/qa/img37/rotating/rotating_eph_heights.png
	new file:   docs/qa/img37/rotating/rotating_peers.png
	new file:   docs/qa/img37/rotating/rotating_txs_rate.png
	new file:   docs/qa/img38/rotating/rotating_avg_memory.png
	new file:   docs/qa/img38/rotating/rotating_block_rate.png
	new file:   docs/qa/img38/rotating/rotating_cpu.png
	new file:   docs/qa/img38/rotating/rotating_eph_heights.png
	new file:   docs/qa/img38/rotating/rotating_latencies.png
	new file:   docs/qa/img38/rotating/rotating_peers.png
	new file:   docs/qa/img38/rotating/rotating_txs_rate.png
	modified:   scripts/qa/reporting/README.md

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/qa/CometBFT-QA-38.md
	both modified:   scripts/qa/reporting/prometheus_plotter.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner May 24, 2023 18:53
@mergify mergify bot added the conflicts label May 24, 2023
@sergio-mena
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor Author

mergify bot commented May 24, 2023

rebase

❌ Unable to rebase: user sergio-mena is unknown.

Details

Please make sure sergio-mena has logged in Mergify dashboard.

* Add `rotating` section, fix x axis formatting

* Regenerate images with fixed x-axis

* Clarify comments

* Adapted v0.38 report sections

* Update docs/qa/CometBFT-QA-38.md

Co-authored-by: Lasaro <lasaro@informal.systems>

* Addressed @lasarojc's comments

* Added issues found

* Update docs/qa/CometBFT-QA-38.md

---------

Co-authored-by: Lasaro <lasaro@informal.systems>
@sergio-mena sergio-mena force-pushed the mergify/bp/v0.38.x/pr-883 branch from dc13237 to 278ff1b Compare May 24, 2023 19:20
@sergio-mena sergio-mena self-assigned this May 24, 2023
@sergio-mena sergio-mena added the qa Quality assurance label May 24, 2023
@sergio-mena sergio-mena merged commit d47ea7a into v0.38.x May 24, 2023
@sergio-mena sergio-mena deleted the mergify/bp/v0.38.x/pr-883 branch May 24, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa Quality assurance

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant