Backport of PR #771 to 0.34 : big int parsing#798
Conversation
Replaced int64 with big.int Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems>
sergio-mena
left a comment
There was a problem hiding this comment.
Only minor comments on v0.34.x <--> v0.37.x discrepancies. I'm interested in the reasons for those
.changelog/unreleased/bug-fixes/771-kvindexer-parsing-big-ints.md
Outdated
Show resolved
Hide resolved
sergio-mena
left a comment
There was a problem hiding this comment.
LGTM.
Please make sure you address @lasarojc's comments
| - `[state/kvindex]` Querying event attributes that are bigger than int64 is now enabled. We are not supporting reading floats from the db into the indexer nor parsing them into BigFloats to not introduce breaking changes in minor releases. | ||
| ([\#771](https://github.com/cometbft/cometbft/pull/771)) No newline at end of file |
There was a problem hiding this comment.
Querying event attributes that are bigger than int64 is now enabled.
This makes sense to me as something to communicate to users.
We are not supporting reading floats from the db into the indexer nor parsing them into BigFloats to not introduce breaking changes in minor releases.
What does this, however, mean for users?
There was a problem hiding this comment.
Maybe this does not have to be in the changelog, but only in the docs. This is basically the same behaviour as they had before, but they might have been unaware of this. I agree that maybe this should be removed frm the changelog but left in the docs.
There was a problem hiding this comment.
Done, let me know if you are ok with merging this.
Co-authored-by: Thane Thomson <connect@thanethomson.com>
|
@thanethomson , I am closing this as the content is in the docs, but feel free to ping me to change the changelog message. |
Closes #726 for 0.34.x
This is a manual backport of #771 because Mergify did not trigger it.