Skip to content

ADR 103 Local State Sync Support (ported from Tendermint Core repo)#729

Closed
adizere wants to merge 2 commits intomainfrom
adi/28_local_sync_adr
Closed

ADR 103 Local State Sync Support (ported from Tendermint Core repo)#729
adizere wants to merge 2 commits intomainfrom
adi/28_local_sync_adr

Conversation

@adizere
Copy link
Contributor

@adizere adizere commented Apr 19, 2023

Closes #28

Rendered view of adr-103-local-state-sync.md

TODOs

  • Cross-validate with the solution in Enable local snapshot restore (backport: #733) #728
  • Update docs to reflect the new workflow, with instructions on how users can do local (out-of-band) state sync
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@adizere
Copy link
Contributor Author

adizere commented Apr 20, 2023

@cason and I decided today on the following:

  • Daniel will rewrite the Context section (in particular Technical context) to describe the two possible implementations that exist towards solving the problem of local state sync
  • Later today, latest Monday, we'll discuss with the rest of the team to understand the tradeoffs between the two candidate solutions. The goal is to get advice and land on a decision regarding which of the two solutions is preferable.
  • After we decide on which solution to adopt, we update the present ADR, in particular the Decision and subsequent sections
  • In the meantime, we'll be looking to test the solution in Enable local snapshot restore (backport: #733) #728 with help from contributors

@chillyvee
Copy link
Contributor

chillyvee commented Apr 20, 2023

Thank you for the notes.

  1. Should we hold until more architectural decisions are made? If you think reviewing a working implementation for Juno v14 is helpful, we can update all the code. But it won't be possible to target main since Juno still targets v0.34
  2. Can decide whether we are targeting v0.34 or main?

@adizere
Copy link
Contributor Author

adizere commented Apr 24, 2023

Thanks for the quick feedback!

If you think reviewing a working implementation for Juno v14 is helpful, we can update all the code. But it won't be possible to target main since Juno still targets v0.34
Can decide whether we are targeting v0.34 or main?

It would be helpful to have instructions on how to use the solution in #728 in Juno (or other live network). Thanks in advance for that! I think targeting v0.34 should be fine.

@github-actions
Copy link

github-actions bot commented May 5, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label May 5, 2023
@cason cason removed the stale For use by stalebot label May 5, 2023
@cason
Copy link

cason commented May 5, 2023

So, for context see: #28 (comment)

@adizere
Copy link
Contributor Author

adizere commented May 7, 2023

Superseded by #801

@adizere adizere closed this May 7, 2023
@adizere adizere added this to the 2023-Q2 milestone May 7, 2023
@adizere adizere deleted the adi/28_local_sync_adr branch May 22, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

State sync from local snapshot: Understand problem, explore solutions

3 participants