Conversation
aljo242
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes a panic from code
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsNote
Replaces panics on total voting power overflow with error returns, adds a safe accessor, and updates callers and tests accordingly.
updateTotalVotingPowernow returnserrorinstead of panicking on overflow; propagates error where applicable.TotalVotingPowerSafe()to compute/return total voting power or an error.TotalVotingPower()now panics only ifupdateTotalVotingPower()returns an error.updateWithChangeSet,ValidatorSetFromProto, andValidatorSetFromExistingValidatorsto handle/propagate errors.types/validator_set_test.go):TestValidatorSetFromProtoReturnsErrorOnOverflow.require.NoErrorfromupdateTotalVotingPower).Written by Cursor Bugbot for commit d7d7ae4. This will update automatically on new commits. Configure here.