Merge feature/abci++vef into feature/proto-upgrade#535
Merged
sergio-mena merged 5 commits intofeature/proto-upgradefrom Mar 14, 2023
Merged
Merge feature/abci++vef into feature/proto-upgrade#535sergio-mena merged 5 commits intofeature/proto-upgradefrom
feature/abci++vef into feature/proto-upgrade#535sergio-mena merged 5 commits intofeature/proto-upgradefrom
Conversation
* [partial cherry-pick] abci: Move `app_hash` parameter from `Commit` to `FinalizeBlock` (#8664) * Removed from proto * make proto-gen * make build works * make some tests pass * Fix TestMempoolTxConcurrentWithCommit * Minor change * Update abci/types/types.go * Update internal/state/execution.go * Update test/e2e/app/state.go Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Updated changelog and `UPGRADING.md` * Fixed abci-cli tests, and doc * Addressed @cmwaters' comments * Addressed @cmwaters' comments, part 2 Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Levftover typo in spec --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* e2e: programmable ABCI method times * fix linting error Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* Pass vote extension signature in `PrepareProposal` * make proto-gen * Verify extensions at PrepareProposal * Addressed @thanethomson's comments * Fix vote extension activation in e2e * ProcessProposal: 1st try * Working.... * Refactoring * Verify signatrue in unit test * spacing * Addressed @lasarojc's comments * Fix test
mzabaluev
approved these changes
Mar 14, 2023
Contributor
mzabaluev
left a comment
There was a problem hiding this comment.
The protobuf changes look good to me.
I trust reviews on the PRs targeting the source branch for the rest of the code changes.
Collaborator
Author
|
@mzabaluev (as I mentioned in Monday's meeting) Bear in mind there's just one more incremental proto change upcoming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title
(it was ff-merge)
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments