refactor: cometbft image build (backport #5179)#5181
Merged
mergify[bot] merged 2 commits intov0.38.xfrom Jun 5, 2025
Merged
Conversation
--- This is a refactor of the CometBFT docker image build. The current state of this build is completely broken. It builds an amd64 and an arm64 version, and publishes each of them individually without doing a multi-arch image. The result is only the arch that finishes last ends up tagged. This PR will make the single-arch builds tagged with arch specific labels, and the current labels with be multi-arch builds. #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit fa76e35) # Conflicts: # .github/workflows/cometbft-docker.yml
Contributor
Author
|
Cherry-pick of fa76e35 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Ironbird - launch a networkTo use Ironbird, you can use the following commands:
Custom Load Test ConfigurationYou can provide a custom load test configuration using the `--load-test-config=` flag:Use |
zrbecker
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor of the CometBFT docker image build.
The current state of this build is completely broken. It builds an amd64 and an arm64 version, and publishes each of them individually without doing a multi-arch image. The result is only the arch that finishes last ends up tagged.
This PR will make the single-arch builds tagged with arch specific labels, and the current labels with be multi-arch builds.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #5179 done by [Mergify](https://mergify.com).