Skip to content

Votes can't have zero height#513

Merged
sergio-mena merged 3 commits intov0.34.xfrom
sergio/10-v034-backport-zero-height-votes
Mar 13, 2023
Merged

Votes can't have zero height#513
sergio-mena merged 3 commits intov0.34.xfrom
sergio/10-v034-backport-zero-height-votes

Conversation

@sergio-mena
Copy link
Collaborator

@sergio-mena sergio-mena commented Mar 13, 2023

Contributes to #510

Manual backport of #511

Sequence:

  1. write failing UT
  2. change prod code to make UT pass

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@sergio-mena sergio-mena added the bug Something isn't working label Mar 13, 2023
@sergio-mena sergio-mena requested a review from a team as a code owner March 13, 2023 11:56
@sergio-mena sergio-mena self-assigned this Mar 13, 2023
@sergio-mena sergio-mena merged commit fed267f into v0.34.x Mar 13, 2023
@sergio-mena sergio-mena deleted the sergio/10-v034-backport-zero-height-votes branch March 13, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants