feat(storage): Export DB interface#4690
Merged
alesforz merged 8 commits intoalesforz/code-uses-storage-pkgfrom Dec 20, 2024
Merged
feat(storage): Export DB interface#4690alesforz merged 8 commits intoalesforz/code-uses-storage-pkgfrom
DB interface#4690alesforz merged 8 commits intoalesforz/code-uses-storage-pkgfrom
Conversation
added 5 commits
December 18, 2024 15:17
`db` exposes the `DB`, `Batch`, and `Iterator` interfaces for users.
5 tasks
melekes
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In reviewing #4601, we discussed about exporting the
DB,Batch, andIteratorinterfaces instead of leaving them in aninternalpackage. After some thinking we decided to export them in a new non-internal packagecmtdb. However, our implementation of those interfaces remain unexported.Changes
This PR adds pkg
cmtdbexporting theDB,Batch, andIteratorinterfaces. Additionally, it changes the code to use this new package rather than the now obsoleteinternal/storage(which this PR removes).PR checklist
[] Changelog entry added in.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments