RFC100: Upgrade path section#451
Merged
sergio-mena merged 10 commits intofeature/abci++veffrom Mar 6, 2023
Merged
Conversation
jmalicevic
approved these changes
Mar 3, 2023
Collaborator
jmalicevic
left a comment
There was a problem hiding this comment.
Minor spelling corrections but good otherwise.
| Additional discussion and implementation of this upgrade strategy can be found | ||
| in GitHub [issue 8453][toggle-vote-extensions]. | ||
|
|
||
| We now explain the changes needed to key solutions/implementation proposed in previous sections. |
Collaborator
There was a problem hiding this comment.
Suggested change
| We now explain the changes needed to key solutions/implementation proposed in previous sections. | |
| We now explain the changes needed to support solutions/implementation proposed in previous sections. | |
| ``` ? |
Collaborator
Author
There was a problem hiding this comment.
I see my sentence was too cryptic. I'll re-word this. Please check the result
|
|
||
| We now explain the changes needed to key solutions/implementation proposed in previous sections. | ||
| For simplicity, in any conditions comparing a height to *h<sub>e</sub>*, | ||
| if *h<sub>e</sub>* is 0 (not set yet) then the condition assumes *h<sub>e</sub> = ∞*. |
Collaborator
There was a problem hiding this comment.
Essentially the considered height will always be considered as less than h_e and thus allow the code to proceed as if it does not need vote extensions?
Collaborator
Author
There was a problem hiding this comment.
Exactly. It's a ruse to not complicate all the conditions that appear below
Collaborator
Author
There was a problem hiding this comment.
If you think that's not clear enough, maybe we can add one sentence
sergio-mena
commented
Mar 3, 2023
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
sergio-mena
commented
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #444
Rendered
In this PR:
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments