Skip to content

Migrate RFC 017 to RFC 100#450

Merged
sergio-mena merged 2 commits intofeature/abci++veffrom
sergio/444-update-rfc017-to-rfc100
Mar 3, 2023
Merged

Migrate RFC 017 to RFC 100#450
sergio-mena merged 2 commits intofeature/abci++veffrom
sergio/444-update-rfc017-to-rfc100

Conversation

@sergio-mena
Copy link
Collaborator

Contributes to #444

This PR is the first step to finishing the RFC containing vote extension propagation.
This first step simply consists in copying RFC017 over to RFC100 and updating all the references to Tendermint Core, retracted/unreleased versions (v0.35.x, v0.36.x) and links to the repo.

IMPORTANT Note for reviewers: when switching to the "Files changed" tab to review, please review the last commit only. The first commit represents text already reviewed and approved last year, so I don't it is worth going through it again.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@sergio-mena sergio-mena requested a review from a team as a code owner March 2, 2023 20:29
@sergio-mena sergio-mena self-assigned this Mar 2, 2023
@sergio-mena sergio-mena added documentation Improvements or additions to documentation abci Application blockchain interface labels Mar 2, 2023

The blocksync reactor featuring light client verification is being actively worked on (tentatively
for v0.37). So it is best if this RFC does not try to delve into that problem, but just makes sure
The blocksync reactor featuring light client verification is among the CometBFT team' current priorities.
Copy link
Collaborator

@jmalicevic jmalicevic Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was what I worked on last year, do we still plan to go ahead with this ? In any case, not relevant for approving this particular PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question :-)
I've just checked and I can't see any issue in CometBFT on this. IIRC it's because we only migrated those issues we'd need for Q1.
An idea would be to go back to the Tendermint Core repo, dig up the set of issues/PRs related to this, and write a tracking issue containing all that info. Then, we could use that issue to prioritize w.r.t. to other things we have on our plate.

Copy link
Collaborator

@jmalicevic jmalicevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the last commit and I assume these are just minor edits before you actually update it with the final version in a subsequent PR.

@sergio-mena sergio-mena mentioned this pull request Mar 2, 2023
3 tasks
@sergio-mena
Copy link
Collaborator Author

I just reviewed the last commit and I assume these are just minor edits before you actually update it with the final version in a subsequent PR.

Exactly

@sergio-mena sergio-mena merged commit 944332d into feature/abci++vef Mar 3, 2023
@sergio-mena sergio-mena deleted the sergio/444-update-rfc017-to-rfc100 branch March 3, 2023 10:38
@thanethomson thanethomson added the rfc Request for comments label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abci Application blockchain interface documentation Improvements or additions to documentation rfc Request for comments

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants