test: fix TestStateDoesntCrashOnInvalidVote (backport #4439)#4440
Merged
mergify[bot] merged 4 commits intov0.38.x-experimentalfrom Nov 6, 2024
Merged
Conversation
(cherry picked from commit d8980f9) # Conflicts: # consensus/state_test.go
Contributor
Author
|
Cherry-pick of d8980f9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
We probably should merge |
Collaborator
That's not how we do it anymore. |
cason
reviewed
Nov 6, 2024
cason
approved these changes
Nov 6, 2024
cason
left a comment
There was a problem hiding this comment.
Diffs match, except for the empty line.
There is a suggestion to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4439 done by [Mergify](https://mergify.com).