Improve wait for node in e2e runner for long catch-up times (backport #375)#435
Merged
sergio-mena merged 6 commits intov0.37.xfrom Mar 1, 2023
Merged
Improve wait for node in e2e runner for long catch-up times (backport #375)#435sergio-mena merged 6 commits intov0.37.xfrom
sergio-mena merged 6 commits intov0.37.xfrom
Conversation
* e2e: Flexible timeout while waiting for a node * QA: added big e2e network manifest * Don't build latest locally, but rely on what has been released * Do not build `latest`=`local` locally. Long test upgrades from `latest` to `local`. * CatchingUp shouldn't be checked when waiting for height 0 * Adjust retention to support evidence gathering * fix typo * More adjestments for long-running e2e manifests * Makes wait proportional to the height, so nodes have more time to cacthup on long runs. Waits for all nodes for the duration of `timeout`, not each node for the duration of `timeout`. --------- Co-authored-by: lasarojc <lasaro@informal.systems> (cherry picked from commit 167a845) # Conflicts: # state/txindex/indexer_service.go
* e2e: Flexible timeout while waiting for a node * QA: added big e2e network manifest * Don't build latest locally, but rely on what has been released * Do not build `latest`=`local` locally. Long test upgrades from `latest` to `local`. * CatchingUp shouldn't be checked when waiting for height 0 * Adjust retention to support evidence gathering * fix typo * More adjestments for long-running e2e manifests * Makes wait proportional to the height, so nodes have more time to cacthup on long runs. Waits for all nodes for the duration of `timeout`, not each node for the duration of `timeout`. --------- Co-authored-by: lasarojc <lasaro@informal.systems>
lasarojc
approved these changes
Mar 1, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #375 done by Mergify.
Cherry-pick of 167a845 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com