refactor(p2p/nodekey)!: remove NodeKey suffix#4304
Merged
Conversation
14 tasks
hvanz
approved these changes
Oct 23, 2024
Collaborator
hvanz
left a comment
There was a problem hiding this comment.
LGTM. Do we need a changelog entry for the breaking change?
ValarDragon
approved these changes
Oct 23, 2024
ddda651 to
48f1cb4
Compare
977d697 to
e784b0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4302
Important: no logic has been changed; just moving stuff and updating interfaces.