chore(RPC): Reduce Genesis Chunks Size#4299
Merged
Conversation
1 task
andynog
approved these changes
Oct 17, 2024
Collaborator
andynog
left a comment
There was a problem hiding this comment.
Seems OK, more chunks will be created but I'm assuming the client side will handle that.
These values are very subjective to network conditions but probably going with a lower value might be beneficial to constrained environments
jmalicevic
reviewed
Oct 17, 2024
melekes
approved these changes
Oct 23, 2024
jmalicevic
approved these changes
Oct 23, 2024
Collaborator
jmalicevic
left a comment
There was a problem hiding this comment.
Approving but add a changelog before mergin plz. Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4298.
PR checklist
[ ]Tests written/updated.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments