kvindexer: porting event sequences and slash parsing to main#423
Merged
jmalicevic merged 14 commits intomainfrom Mar 21, 2023
Merged
kvindexer: porting event sequences and slash parsing to main#423jmalicevic merged 14 commits intomainfrom
jmalicevic merged 14 commits intomainfrom
Conversation
* state/kvindexer: associate event attributes with events (#9759) Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Romain Ruetschi <romain.ruetschi@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> * Backport kvindexer fix Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> * By event search is now default behaviour. Including fixes from PRs added to 0.34 Co-authored-by: Lasaro <lasaro@gmail.com>
* txindexer handles slashes in event value * Update .changelog/unreleased/bug-fixes/382-txindexer-fix-slash-parsing.md Co-authored-by: Thane Thomson <connect@thanethomson.com> --------- Co-authored-by: Thane Thomson <connect@thanethomson.com>
sergio-mena
reviewed
Mar 14, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Reviewed as a (composite) cherry-pick
Co-authored-by: Sergio Mena <sergio@informal.systems>
…tbft into jasmina/kvindexer-fix-0.38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds to the kvindexer the ability to query attributes only if they match within the same event by cherry-picking commit 21c00c5 (same behaviour introduced to v0.37.x in #77 ).
Additionally, it includes the fix needed for the indexer to parse correctly queries where the attribute value contains a
/symbol - cheery-picking commit: c676b8a (added to v0.37.x in #382 ).This PR was tested with the following tests:
make test