config: mark block_sync key as deprecated#414
Conversation
v0.37.x
v0.37.xblock_sync key as deprecated
.changelog/unreleased/breaking-changes/409-deprecate-blocksyncmode
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergio Mena <sergio@informal.systems>
…mode Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
|
@sergio-mena Thanks for the suggestions! |
|
As a general comment here, do you think most users will understand what we mean with this messages? Maybe we should make clear that the flag (and section) about blocksync will be removed... |
|
@cason We decided not to remove the BlockSync section and the version field because we will add more versions in the future. We are just removing the flag, for which there enough messages for the users as log warnings, comments, and in the changelog. I agree though that is not the best to rename a flag and remove it all in the same release. |
|
Hey, I was more considering the wording of the message. I would be for a more direct message, such as: "Block Sync cannot be disabled", instead of "BlockSync will be enabled unconditionally". |
|
@cason I made it more explicit in the messages that we are removing the key. |
Co-authored-by: Daniel <daniel.cason@informal.systems>
Part of #409
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments