Skip to content

config: mark block_sync key as deprecated#414

Merged
hvanz merged 16 commits intov0.37.xfrom
hernan/409-deprecate-blocksyncmode
Mar 6, 2023
Merged

config: mark block_sync key as deprecated#414
hvanz merged 16 commits intov0.37.xfrom
hernan/409-deprecate-blocksyncmode

Conversation

@hvanz
Copy link
Collaborator

@hvanz hvanz commented Feb 28, 2023

Part of #409


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@hvanz hvanz changed the title Mark BlockSyncMode config as deprecated Mark BlockSyncMode config as deprecated in v0.37.x Feb 28, 2023
@hvanz hvanz self-assigned this Feb 28, 2023
@hvanz hvanz marked this pull request as ready for review March 1, 2023 09:47
@hvanz hvanz requested a review from a team as a code owner March 1, 2023 09:47
@hvanz hvanz changed the title Mark BlockSyncMode config as deprecated in v0.37.x config: mark block_sync key as deprecated Mar 1, 2023
hvanz and others added 6 commits March 1, 2023 12:37
Co-authored-by: Sergio Mena <sergio@informal.systems>
…mode

Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
@hvanz
Copy link
Collaborator Author

hvanz commented Mar 1, 2023

@sergio-mena Thanks for the suggestions!

@cason
Copy link

cason commented Mar 1, 2023

As a general comment here, do you think most users will understand what we mean with this messages? Maybe we should make clear that the flag (and section) about blocksync will be removed...

@hvanz
Copy link
Collaborator Author

hvanz commented Mar 2, 2023

@cason We decided not to remove the BlockSync section and the version field because we will add more versions in the future. We are just removing the flag, for which there enough messages for the users as log warnings, comments, and in the changelog. I agree though that is not the best to rename a flag and remove it all in the same release.

@cason
Copy link

cason commented Mar 2, 2023

Hey, I was more considering the wording of the message. I would be for a more direct message, such as: "Block Sync cannot be disabled", instead of "BlockSync will be enabled unconditionally".

@hvanz
Copy link
Collaborator Author

hvanz commented Mar 2, 2023

@cason I made it more explicit in the messages that we are removing the key.

hvanz and others added 2 commits March 2, 2023 12:27
@hvanz hvanz merged commit 2dd008d into v0.37.x Mar 6, 2023
@hvanz hvanz deleted the hernan/409-deprecate-blocksyncmode branch March 6, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants