mempool: Fix the benchmarks (backport #934) (backport #3893)#3894
Merged
hvanz merged 2 commits intov0.38.x-experimentalfrom Sep 2, 2024
Merged
mempool: Fix the benchmarks (backport #934) (backport #3893)#3894hvanz merged 2 commits intov0.38.x-experimentalfrom
hvanz merged 2 commits intov0.38.x-experimentalfrom
Conversation
The mempool [benchmarks](https://github.com/cometbft/cometbft/blob/main/mempool/bench_test.go) were invalid due to an incorrect transaction payload. To see this, one may run `go test -v -count 1 -bench ^BenchmarkCheckTx$ -test.run ^$` against `main` from the `mempool` directory. These modificationss fix such a problem and add a new benchmark to exercice`mempool:update`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #934 done by [Mergify](https://mergify.com). --------- Co-authored-by: Pierre Sutra <0track@gmail.com> Co-authored-by: hvanz <hernan.vanzetto@gmail.com> (cherry picked from commit 969c8d1)
hvanz
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mempool benchmarks were invalid due to an incorrect transaction payload. To see this, one may run
go test -v -count 1 -bench ^BenchmarkCheckTx$ -test.run ^$againstmainfrom themempooldirectory. These modificationss fix such a problem and add a new benchmark to exercicemempool:update.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #934 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #3893 done by [Mergify](https://mergify.com).