feat(tools): remove tools package (backport #2046)#3760
Merged
Conversation
- 1) protos are now built with the sdk's proto builder - 2) go tools methodology just bloats .mod and .sum making comet harder to work with - 3) tidy: mod and sum don't have maintenance tools in them anymore - 4) stop using an abandoned Dockerfile --------- tl;dr: by removing things from go.mod we can make comet easier to maintain, even if that means less stylish golang. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 2bbb5c1) # Conflicts: # go.mod # go.sum # scripts/mockery_generate.sh # tools/README.md # tools/proto/Dockerfile # types/params.go
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
since go: github.com/creachadair/taskgroup@v0.9.1: module github.com/creachadair/taskgroup@v0.9.1 requires go >= 1.22 (running go 1.21.4; GOTOOLCHAIN=local)
Collaborator
|
blocked by #3754 |
must match cometbft-db version
sergio-mena
approved these changes
Aug 20, 2024
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
This is a HCF applied to v0.34.x. 👍
tools package (backport #2046)tools package (backport #2046)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: by removing things from go.mod we can make comet easier to maintain, even if that means less stylish golang.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #2046 done by [Mergify](https://mergify.com).