test(mempool): Allow custom log levels on reactor tests (backport #3719)#3753
Merged
test(mempool): Allow custom log levels on reactor tests (backport #3719)#3753
Conversation
Also disable the P2P log messages on the switches, which are not relevant for mempool. In particular, this PR changes the log level of `TestReactor_MaxTxBytes`, which is very verbose and it currently could take 12s with the default "debug" level. With "info" level it takes 300ms. For reviewers, the PR can be reviewed commit by commit. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 4c598bf) # Conflicts: # mempool/reactor_test.go
This comment was marked as resolved.
This comment was marked as resolved.
hvanz
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also disable the P2P log messages on the switches, which are not relevant for mempool.
In particular, this PR changes the log level of
TestReactor_MaxTxBytes, which is very verbose and it currently could take 12s with the default "debug" level. With "info" level it takes 300ms.For reviewers, the PR can be reviewed commit by commit.
This is an automatic backport of pull request #3719 done by [Mergify](https://mergify.com).