chore(state): Copy Iterator Key() and Value() APIs return values. (backport #3541)#3598
Merged
chore(state): Copy Iterator Key() and Value() APIs return values. (backport #3541)#3598
Iterator Key() and Value() APIs return values. (backport #3541)#3598Conversation
…s. (#3541) Related to cometbft/cometbft-db#168. #### Changes We recently updated cometbft-db `Iterator` type `Key()` and `Value()` APIs to return their values directly instead of a copy. Therefore, this PR ensures that code in cometbft that modifies or stores references to the return value of those APIs creates a copy before continuing. --- #### PR checklist ~- [ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 3be35f0)
alesforz
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to cometbft/cometbft-db#168.
Changes
We recently updated cometbft-db
IteratortypeKey()andValue()APIs to return their values directly instead of a copy.Therefore, this PR ensures that code in cometbft that modifies or stores references to the return value of those APIs creates a copy before continuing.
PR checklist
- [ ] Tests written/updated.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #3541 done by [Mergify](https://mergify.com).