Skip to content

feat: do not start indexer service (back port: #3331)#3496

Merged
melekes merged 2 commits intocometbft:v0.38.xfrom
mmsqe:v0.38.x_backport_3331
Jul 11, 2024
Merged

feat: do not start indexer service (back port: #3331)#3496
melekes merged 2 commits intocometbft:v0.38.xfrom
mmsqe:v0.38.x_backport_3331

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jul 11, 2024

if block && tx indexers are no-op


  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

if block && tx indexers are no-op

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
@mmsqe mmsqe requested a review from a team as a code owner July 11, 2024 06:18
@melekes
Copy link
Collaborator

melekes commented Jul 11, 2024

The PR breaks the Go API, so we can't backport it. However, we can backport it to the v0.38-experimental branch if you want.

@melekes melekes closed this Jul 11, 2024
@mmsqe
Copy link
Contributor Author

mmsqe commented Jul 11, 2024

The PR breaks the Go API, so we can't backport it. However, we can backport it to the v0.38-experimental branch if you want.

@melekes Got it thanks, not sure if can add extra IndexerFromConfigWithDisabledIndexers without changing exist one?

@melekes
Copy link
Collaborator

melekes commented Jul 11, 2024

The PR breaks the Go API, so we can't backport it. However, we can backport it to the v0.38-experimental branch if you want.

@melekes Got it thanks, not sure if can add extra IndexerFromConfigWithDisabledIndexers without changing exist one?

Yes we can!

@melekes melekes reopened this Jul 11, 2024
Copy link
Collaborator

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants