Skip to content

refactor(state): reuse method proposalIsTimely#2962

Merged
sergio-mena merged 1 commit intomainfrom
sergio/istimely-small-refactor
May 2, 2024
Merged

refactor(state): reuse method proposalIsTimely#2962
sergio-mena merged 1 commit intomainfrom
sergio/istimely-small-refactor

Conversation

@sergio-mena
Copy link
Collaborator

@sergio-mena sergio-mena commented May 1, 2024

Small refactor to simplify the calls to "is timely"


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

@sergio-mena sergio-mena self-assigned this May 1, 2024
@sergio-mena sergio-mena requested a review from a team as a code owner May 1, 2024 12:24
@sergio-mena sergio-mena requested a review from a team May 1, 2024 12:24
Copy link
Collaborator

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sergio-mena sergio-mena added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 4eeb9aa May 2, 2024
@sergio-mena sergio-mena deleted the sergio/istimely-small-refactor branch May 2, 2024 08:14
@cason
Copy link

cason commented May 7, 2024

Shouldn't this go to v1 too?

@sergio-mena
Copy link
Collaborator Author

Shouldn't this go to v1 too?

It's just a small refactor. I don't think it's worth the hassle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants