Skip to content

perf(consensus/state): Change finalizeCommit to use applyVerifiedBlock (backport #2928)#2943

Merged
melekes merged 1 commit intov1.xfrom
mergify/bp/v1.x/pr-2928
Apr 30, 2024
Merged

perf(consensus/state): Change finalizeCommit to use applyVerifiedBlock (backport #2928)#2943
melekes merged 1 commit intov1.xfrom
mergify/bp/v1.x/pr-2928

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 30, 2024

Simplest component of #2854

We already run ValidateBlock in finalizeCommit, so this PR removes one extra redundant call by using ApplyVerifiedBlock. (The other call is also redundant, but that likely requires a more complex caching strategy as noted in #2854 to remedy)

From my understanding of these benchmarks, at Osmosis 150 validators, this should be saving ~13ms of execution time per block.


PR checklist

  • Tests written/updated - Theres no test to update, as its impossible to reach the difference in codepaths!
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

This is an automatic backport of pull request #2928 done by [Mergify](https://mergify.com).

#2928)

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

Simplest component of #2854

We already run ValidateBlock in finalizeCommit, so this PR removes one
extra redundant call by using ApplyVerifiedBlock. (The other call is
also redundant, but that likely requires a more complex caching strategy
as noted in #2854 to remedy)

From my understanding of these benchmarks, at Osmosis 150 validators,
this should be saving ~13ms of execution time per block.

---

#### PR checklist

- [X] Tests written/updated - Theres no test to update, as its
impossible to reach the difference in codepaths!
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

(cherry picked from commit 94fa3c9)
@mergify mergify bot requested a review from a team as a code owner April 30, 2024 09:19
@mergify mergify bot requested a review from a team April 30, 2024 09:19
@melekes melekes merged commit 31ec4f9 into v1.x Apr 30, 2024
@melekes melekes deleted the mergify/bp/v1.x/pr-2928 branch April 30, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants