Skip to content

fix: BootstrapState use custom genesis doc provider (backport #2791)#2796

Merged
andynog merged 3 commits intov1.xfrom
mergify/bp/v1.x/pr-2791
Apr 12, 2024
Merged

fix: BootstrapState use custom genesis doc provider (backport #2791)#2796
andynog merged 3 commits intov1.xfrom
mergify/bp/v1.x/pr-2791

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 12, 2024

The cosmos-sdk 0.50 genesis doc marshalling not being compatible with the cometbft default one (see cosmos/cosmos-sdk#18477), so we need to support custom genesis doc provider in this public API as well, it's called by the bootstrap-state command in cosmos-sdk.

Please backport to 0.38, the SDK 0.50 bootstrap-state command is already broken.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

This is an automatic backport of pull request #2791 done by [Mergify](https://mergify.com).

The cosmos-sdk 0.50 genesis doc marshalling not being compatible with
the cometbft default one (see
cosmos/cosmos-sdk#18477), so we need to
support custom genesis doc provider in this public API as well, it's
called by the `bootstrap-state` command in cosmos-sdk.

Please backport to 0.38, the SDK 0.50 `bootstrap-state` command is
already broken.

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

(cherry picked from commit 7279fe8)
@mergify mergify bot requested a review from a team as a code owner April 12, 2024 07:53
@mergify mergify bot requested a review from a team April 12, 2024 07:53
@andynog andynog merged commit 38b4f09 into v1.x Apr 12, 2024
@andynog andynog deleted the mergify/bp/v1.x/pr-2791 branch April 12, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants