Skip to content

test(abci): update e2e tests to check against ABCI 2.0 grammar (backport #2201)#2549

Merged
sergio-mena merged 1 commit intov1.xfrom
mergify/bp/v1.x/pr-2201
Mar 8, 2024
Merged

test(abci): update e2e tests to check against ABCI 2.0 grammar (backport #2201)#2549
sergio-mena merged 1 commit intov1.xfrom
mergify/bp/v1.x/pr-2201

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 8, 2024

This is an automatic backport of pull request #2201 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

This PR partially closes #1404. Namely, it updates the grammar and other
parts of the code to be able to check whether CometBFT respects ABCI
2.0. The only thing missing is to update ADR when this implementation is
accepted.

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: nenadmilosevic95 <nenad@informal.systems>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Daniel <daniel.cason@informal.systems>
(cherry picked from commit 9f02125)
@mergify mergify bot requested a review from a team as a code owner March 8, 2024 20:34
@mergify mergify bot requested a review from a team March 8, 2024 20:34
@sergio-mena sergio-mena self-assigned this Mar 8, 2024
@sergio-mena sergio-mena added the e2e Related to our end-to-end tests label Mar 8, 2024
@sergio-mena sergio-mena merged commit 75e6d62 into v1.x Mar 8, 2024
@sergio-mena sergio-mena deleted the mergify/bp/v1.x/pr-2201 branch March 8, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Related to our end-to-end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants