spec(proto): add cometbft.privval.v1beta2 proto package (backport #2529)#2530
Merged
spec(proto): add cometbft.privval.v1beta2 proto package (backport #2529)#2530
cometbft.privval.v1beta2 proto package (backport #2529)#2530Conversation
The package is added to represent the privval protocol in CometBFT 0.38.x, since the added field in `SignVoteRequest` (in a string of PRs ending in #2522) and removal of the (unused) `Errors` enum make v1 different. --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 99a5794)
melekes
approved these changes
Mar 6, 2024
| import "tendermint/types/types.proto"; | ||
| import "gogoproto/gogo.proto"; | ||
|
|
||
| enum Errors { |
Contributor
There was a problem hiding this comment.
Yes, I believe this enum is not used in Go code as well, at least not in code using cometbft.privval.v1. As tendermint.privval should be in sync with v1, it was left there by oversight.
Collaborator
There was a problem hiding this comment.
Shouldn't we nuke all tendermint protos at this stage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2529 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com