Skip to content

refactor!: Implement RFC 106: remove GetLatestBlock* methods from data companion API (backport #2240)#2251

Merged
melekes merged 3 commits intov1.xfrom
mergify/bp/v1.x/pr-2240
Feb 7, 2024
Merged

refactor!: Implement RFC 106: remove GetLatestBlock* methods from data companion API (backport #2240)#2251
melekes merged 3 commits intov1.xfrom
mergify/bp/v1.x/pr-2240

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 6, 2024

This is an automatic backport of pull request #2240 done by Mergify.
Cherry-pick of 27dfc2a has failed:

On branch mergify/bp/v1.x/pr-2240
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit 27dfc2a0e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changelog/unreleased/breaking-changes/2230-rfc-106-remove-get-latest-block.md
	modified:   api/cometbft/services/block/v1/block.pb.go
	modified:   api/cometbft/services/block/v1/block_service.pb.go
	modified:   api/cometbft/services/block_results/v1/block_results.pb.go
	modified:   api/cometbft/services/block_results/v1/block_results_service.pb.go
	modified:   proto/cometbft/services/block/v1/block.proto
	modified:   proto/cometbft/services/block/v1/block_service.proto
	modified:   proto/cometbft/services/block_results/v1/block_results.proto
	modified:   proto/cometbft/services/block_results/v1/block_results_service.proto
	modified:   proto/tendermint/services/block/v1/block.proto
	modified:   proto/tendermint/services/block/v1/block_service.proto
	modified:   proto/tendermint/services/block_results/v1/block_results.proto
	modified:   proto/tendermint/services/block_results/v1/block_results_service.proto
	modified:   rpc/grpc/server/services/blockresultservice/service.go
	modified:   rpc/grpc/server/services/blockservice/service.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rpc/grpc/client/block_results_service.go
	both modified:   rpc/grpc/client/block_service.go
	both modified:   test/e2e/tests/grpc_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner February 6, 2024 09:50
@mergify mergify bot requested a review from a team February 6, 2024 09:50
@mergify mergify bot added the conflicts label Feb 6, 2024
Resolves #2230

(cherry picked from commit 27dfc2a)
@mzabaluev mzabaluev force-pushed the mergify/bp/v1.x/pr-2240 branch from 785f2b8 to 1eaf4ea Compare February 6, 2024 11:17
@mzabaluev mzabaluev requested a review from melekes February 6, 2024 11:18
@melekes melekes merged commit 4d6131b into v1.x Feb 7, 2024
@melekes melekes deleted the mergify/bp/v1.x/pr-2240 branch February 7, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants