test(mempool): fix TestMempoolUpdateDoesNotPanicWhenApplicationMissedTx (backport #2242)#2247
Merged
test(mempool): fix TestMempoolUpdateDoesNotPanicWhenApplicationMissedTx (backport #2242)#2247
Conversation
…Tx (#2242) The test `TestMempoolUpdateDoesNotPanicWhenApplicationMissedTx` has two problems: - First, the test calls `reqRes.InvokeCallback()` on every CheckTx request-response, but there's no callback set on `reqRes` so the tx are not really added to the mempool at this point. - Near the end, it makes two calls to `callback` on requests of type `CHECK_TX_TYPE_CHECK` when they should be of type `CHECK_TX_TYPE_RECHECK`. The intention here was to process the recheck responses; instead, the two txs are added to the mempool. (cherry picked from commit 71dbb46) # Conflicts: # mempool/clist_mempool_test.go
hvanz
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2242 done by Mergify.
Cherry-pick of 71dbb46 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com