e2e: test vote extension activation via InitChain and FinalizeBlock (backport #2066)#2083
Merged
sergio-mena merged 3 commits intov1.xfrom Jan 22, 2024
Merged
e2e: test vote extension activation via InitChain and FinalizeBlock (backport #2066)#2083sergio-mena merged 3 commits intov1.xfrom
e2e: test vote extension activation via InitChain and FinalizeBlock (backport #2066)#2083sergio-mena merged 3 commits intov1.xfrom
Conversation
…ock` (#2066) Closes #2065 This PR introduces a new `e2e` manifest option `VoteExtensionsUpdateHeight`, which allows the `e2e` application to test vote extension activation mechanisms other than via genesis file. The value of `VoteExtensionsUpdateHeight` is interpreted as follows: * -1: the value of `VoteExtensionsEnableHeight` is to be set in the genesis file (this is equivalent to the mechanism currently present in `e2e`) * 0: the value of `VoteExtensionsEnableHeight` is to be set in `InitChainResponse` * _H_ (where _H_ >= `InitialHeight`, and _H_ < `VoteExtensionsEnableHeight`): the value of `VoteExtensionsEnableHeight` is set in the `FinalizeBlockResponse` corresponding to height _H_ (i.e., at the end of height _H_) The PR also extends the manifest generator to produce different (valid) values of the new option `VoteExtensionsUpdateHeight` in combination with `VoteExtensionsEnableHeight` --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit eab2355) # Conflicts: # .changelog/unreleased/improvements/1958-disable-linting.md
…ock` (#2066) Closes #2065 This PR introduces a new `e2e` manifest option `VoteExtensionsUpdateHeight`, which allows the `e2e` application to test vote extension activation mechanisms other than via genesis file. The value of `VoteExtensionsUpdateHeight` is interpreted as follows: * -1: the value of `VoteExtensionsEnableHeight` is to be set in the genesis file (this is equivalent to the mechanism currently present in `e2e`) * 0: the value of `VoteExtensionsEnableHeight` is to be set in `InitChainResponse` * _H_ (where _H_ >= `InitialHeight`, and _H_ < `VoteExtensionsEnableHeight`): the value of `VoteExtensionsEnableHeight` is set in the `FinalizeBlockResponse` corresponding to height _H_ (i.e., at the end of height _H_) The PR also extends the manifest generator to produce different (valid) values of the new option `VoteExtensionsUpdateHeight` in combination with `VoteExtensionsEnableHeight` --- - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
sergio-mena
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2066 done by Mergify.
Cherry-pick of eab2355 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com