Skip to content

Upgrade to Go 1.19 on main#206

Merged
lasarojc merged 7 commits intomainfrom
thane/174-go1.19
Feb 20, 2023
Merged

Upgrade to Go 1.19 on main#206
lasarojc merged 7 commits intomainfrom
thane/174-go1.19

Conversation

@thanethomson
Copy link
Contributor

Partially addresses #174.

The SDK uses Go 1.19 from their release that integrates with v0.37, so this should be backported to v0.37.x too.


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

Signed-off-by: Thane Thomson <connect@thanethomson.com>
This was referenced Jan 25, 2023
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label Feb 5, 2023
@thanethomson thanethomson added wip Work in progress and removed stale For use by stalebot labels Feb 5, 2023
@lasarojc lasarojc marked this pull request as ready for review February 20, 2023 13:19
@lasarojc lasarojc requested a review from a team as a code owner February 20, 2023 13:19
@sergio-mena
Copy link
Collaborator

We probably want to update these occurrences as well:

% find . -type f | grep -v '\.svg$' | xargs grep -n '[^\.]1\.18[^\.0-9]'
./README.md:63:| v0.34.x          | Go version  | Go 1.18 or higher |
./.github/workflows/e2e-nightly-34x.yml:24:          go-version: '1.18'
%

@lasarojc
Copy link
Contributor

find . -type f | grep -v '.svg$' | xargs grep -n '[^\.]1.18[^\.0-9]'

These pertain to the 0.34 branch. They should be fixed on v0.34.x and forward ported to main and 0.37.

@sergio-mena
Copy link
Collaborator

find . -type f | grep -v '.svg$' | xargs grep -n '[^\.]1.18[^\.0-9]'

These pertain to the 0.34 branch. They should be fixed on v0.34.x and forward ported to main and 0.37.

Ah! You're right... didn't notice in which context they were!

…ing just 1.19. This hould be reverted later.
@lasarojc lasarojc added automerge and removed wip Work in progress labels Feb 20, 2023
@lasarojc lasarojc merged commit 8ffeb61 into main Feb 20, 2023
@lasarojc lasarojc deleted the thane/174-go1.19 branch February 20, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants