Skip to content

feat(rpc): Use default port for HTTP(S) URLs when there is no explicit port (backport #1903)#2053

Merged
melekes merged 3 commits intov0.38.xfrom
mergify/bp/v0.38.x/pr-1903
Jan 17, 2024
Merged

feat(rpc): Use default port for HTTP(S) URLs when there is no explicit port (backport #1903)#2053
melekes merged 3 commits intov0.38.xfrom
mergify/bp/v0.38.x/pr-1903

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 16, 2024

This is an automatic backport of pull request #1903 done by Mergify.
Cherry-pick of 9c9ffba has failed:

On branch mergify/bp/v0.38.x/pr-1903
Your branch is up to date with 'origin/v0.38.x'.

You are currently cherry-picking commit 9c9ffba6c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changelog/unreleased/improvements/1902-rpc-default-port.md
	modified:   rpc/jsonrpc/client/http_json_client.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rpc/jsonrpc/client/http_json_client_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…t port (#1903)

Closes #1902

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments

(cherry picked from commit 9c9ffba)

# Conflicts:
#	rpc/jsonrpc/client/http_json_client_test.go
@mergify mergify bot requested a review from a team as a code owner January 16, 2024 11:11
@mergify mergify bot added the conflicts label Jan 16, 2024
@melekes melekes merged commit f7cbf1d into v0.38.x Jan 17, 2024
@melekes melekes deleted the mergify/bp/v0.38.x/pr-1903 branch January 17, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants