Introduce countAllSignatures in VerifyCommitLight & VerifyCommitLightTrusting (backport of #1806)#1815
Merged
sergio-mena merged 2 commits intov0.34.xfrom Dec 14, 2023
Merged
Conversation
melekes
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1749
Manual backport of #1806
I added the corresponding changes to
v1andv2of blocksync, which are still present in this version.I could not adapt the e2e-repro changes, as this version's e2e code only checks for double-voting. Nevertheless the changes to unit tests, which could be backported, are still testing the code changes.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments