Skip to content

backport to v1.x: types: validate Validator#Address field (#1715)#1728

Merged
melekes merged 1 commit intov1.xfrom
thane/v1.x/backport-1715
Dec 2, 2023
Merged

backport to v1.x: types: validate Validator#Address field (#1715)#1728
melekes merged 1 commit intov1.xfrom
thane/v1.x/backport-1715

Conversation

@thanethomson
Copy link
Contributor

Manual backport of #1715 to v1.x, since I forgot to add the Mergify config until #1724.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

* types: validate Validator#Address field

* fix TestProposerSelection3

* add a changelog entry

* fix two more tests

* Update .changelog/unreleased/improvements/1715-validate-validator-address

Co-authored-by: Thane Thomson <connect@thanethomson.com>

---------

Co-authored-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from melekes December 1, 2023 21:22
@thanethomson thanethomson requested a review from a team as a code owner December 1, 2023 21:22
@thanethomson thanethomson requested a review from a team December 1, 2023 21:22
Copy link
Collaborator

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes merged commit a4a5c43 into v1.x Dec 2, 2023
@melekes melekes deleted the thane/v1.x/backport-1715 branch December 2, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants