Skip to content

v0.38.x-experimental:merge latest changes from v0.38.x#1636

Merged
thanethomson merged 11 commits intov0.38.x-experimentalfrom
jasmina/merge-0.38-to-experimental
Nov 16, 2023
Merged

v0.38.x-experimental:merge latest changes from v0.38.x#1636
thanethomson merged 11 commits intov0.38.x-experimentalfrom
jasmina/merge-0.38-to-experimental

Conversation

@jmalicevic
Copy link
Collaborator

Merging latest changes to v0.38.x-experimental


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

dependabot bot and others added 11 commits October 30, 2023 15:45
)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.27.1 to 1.27.2.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.27.1...v1.27.2)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Max byte check (#1384)

* Update go version

go1.21.1 has security fixes

* Update go.mod to reflect go version and module

* Update to 0.38

* Update formatting

* Update to 0.38

* Update formatting

* Refactor PrepareProposal to handle transaction size limit

* Update go version

go1.21.1 has security fixes

* Update go.mod to reflect go version and module

* Update to 0.38

* Update formatting

* Refactor PrepareProposal to handle transaction size limit

* Fix passage sequence

* Fix passage sequence

(cherry picked from commit c9b75f5)

# Conflicts:
#	docs/guides/go-built-in.md
#	docs/guides/go.md

* Update go-built-in.md

Solving conflict.

* Update go.md

solving conflict

---------

Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
Co-authored-by: lasaro <lasaro@informal.systems>
* mempool: Add metric size of pool in bytes (#1512)

* mempool: Add metric `SizeBytes`

* Safe concurrent read of txsBytes

* Add changelog

(cherry picked from commit b50bca3)

# Conflicts:
#	mempool/metrics.gen.go

* Solving conflict

* Updating grpc and net modules

* Updating grpc and net modules

* Revert "Updating grpc and net modules"

This reverts commit 7bf2645.

* Revert "Updating grpc and net modules"

This reverts commit ba4000f.

---------

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: lasarojc <lasaro@informal.systems>
)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.27.2 to 1.28.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.27.2...v1.28.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Experimental - Reduce # of connections effectively used to gossip transactions out (#1558)

* maxpeers for mempool

* mempool: fix max_peers bcast routine active flag

* Use semaphore to limit concurrency

* Rename MaxPeers to MaxOutboundPeers

* Add max_outbound_peers to config toml template

* Rename in error message

* Renams the parameter to highlight its experimental nature. Extend the AddPeer method to return an error. Moves the semaphone to outside the broadcast routine

* reverting the addition of error to AddPeer. It fails if the context is done and handling this case will be done some other time, when an actual context is passed into acquire.

* reverting the addition of error to AddPeer. It fails if the context is done and handling this case will be done some other time, when an actual context is passed into acquire.

* Fixing lint issue

* renaming semaphore to something more meaningful

* make default value 0, which is the same as the current behavior. 10 is the recommended value.

* adding new flag to manifest.go

* Adding changelog

* Improve the description of the parameter in the generated config file.

* Add metric to track the current number of active connections.

* Change metric to gauge type and rename it.

* e2e: Allow disabling the PEX reactor on all nodes in the testnet

* Apply suggestions from code review

Co-authored-by: Sergio Mena <sergio@informal.systems>

* Update config/config.go comment

* fix lint error

* Improve config description

* Rename metric (remove experimental prefix)

* Add unit test

* Improve unit test

* Update mempool/reactor.go comment

---------

Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Daniel Cason <daniel.cason@informal.systems>
Co-authored-by: lasarojc <lasaro@informal.systems>
Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Sergio Mena <sergio@informal.systems>

* Updating test file, leaving it broken for now

* mempool: Limit gossip connections to persistent and non-persistent peers (experimental) (#1584)

* Ignore persistent peers from limiting of outbound connections

* Update 1558-experimental-gossip-limiting.md

Update changeling

* Fix typo in mempool/metrics.go

* Use two independent configs and semaphores for persistent and non-persistent peers

* Forgot to rename in test

* Update metric description

* Rename semaphores

* Add comment to unit test

---------

Co-authored-by: hvanz <hernan.vanzetto@gmail.com>

* Reverting to old way of reporting errors

* Reverting change that shouldn't have been included in cherry-pick

* Reverting tests to use older functions

* fix rebase merge

---------

Co-authored-by: Adi Seredinschi <adizere@gmail.com>
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Daniel Cason <daniel.cason@informal.systems>
Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Fixes the following compilation error:

```
../../../go/pkg/mod/github.com/cosmos/gogoproto@v1.4.6/proto/merge.go:123:28:
type func(x *descriptorpb.FileDescriptorProto, y
*descriptorpb.FileDescriptorProto) bool of func(x, y
*descriptorpb.FileDescriptorProto) bool {…} does not match inferred type
func(a *descriptorpb.FileDescriptorProto, b
*descriptorpb.FileDescriptorProto) int for func(a E, b E) int
```

go: go1.21.3 darwin/amd64
cometbft: v0.38.0
…s the order of transactions in the receiving reactor. (#1627)
* Bump Go version to v1.21

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Bump minimum Go version in Dockerfiles

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Bump Go version in fuzz tests

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Bump all Go versions used in CI

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: lasaro <lasaro@informal.systems>
* Update SECURITY.md (#1626)

Signed-off-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit 62a97f2)

# Conflicts:
#	SECURITY.md

* Resolve conflicts

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
@jmalicevic jmalicevic added this to the 2023-Q4 milestone Nov 16, 2023
@jmalicevic jmalicevic self-assigned this Nov 16, 2023
@jmalicevic jmalicevic requested a review from a team as a code owner November 16, 2023 12:14
@jmalicevic jmalicevic changed the title Jasmina/merge 0.38 to experimental v0.38.x-experimental:merge latest changes from v0.38.x Nov 16, 2023
@thanethomson thanethomson merged commit d28fe3a into v0.38.x-experimental Nov 16, 2023
@thanethomson thanethomson deleted the jasmina/merge-0.38-to-experimental branch November 16, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants