Merged
Conversation
jmalicevic
reviewed
Jan 20, 2023
| thisConfig := ResetConfig(fmt.Sprintf("%s_%d", testName, i)) | ||
| defer os.RemoveAll(thisConfig.RootDir) | ||
| ensureDir(path.Dir(thisConfig.Consensus.WalFile()), 0700) // dir for wal | ||
| ensureDir(path.Dir(thisConfig.Consensus.WalFile()), 0o700) // dir for wal |
Collaborator
There was a problem hiding this comment.
Why is this extra 0 added here?
Contributor
Author
There was a problem hiding this comment.
This is gofmt's doing. It changes octal numbers to follow the new standard, prefixing with 0o instead of just 0.
Ref: golang/go#33363
Collaborator
There was a problem hiding this comment.
Do you think it will break something with regards to data serialization or its just permissions on the file?
Contributor
Author
There was a problem hiding this comment.
I don't think it will break anything as it only changes the syntax but the compiled value remains the same.
Contributor
Author
There was a problem hiding this comment.
this is the right link https://tip.golang.org/doc/go1.13#gofmt
jmalicevic
reviewed
Jan 20, 2023
| func loadPrivValidator(config *cfg.Config) *privval.FilePV { | ||
| privValidatorKeyFile := config.PrivValidatorKeyFile() | ||
| ensureDir(filepath.Dir(privValidatorKeyFile), 0700) | ||
| ensureDir(filepath.Dir(privValidatorKeyFile), 0o700) |
Collaborator
There was a problem hiding this comment.
Same here, extra character added.
jmalicevic
approved these changes
Jan 20, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134
Based on #135
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed