v0.38.x: Fix linting (backport #1531)#1537
Merged
jmalicevic merged 2 commits intov0.38.xfrom Oct 26, 2023
Merged
Conversation
* Fix linting * Addressed comments * Remove nolint in `psql.go` * state/indexer: override goconst lint in psql Should probably use some smarter format strings * Reverted some changes not needed --------- Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems> (cherry picked from commit 822b277) # Conflicts: # test/e2e/app/app.go
main (backport #1531)
sergio-mena
approved these changes
Oct 25, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Checked diff-of-diffs, LGTM
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1531 done by Mergify.
Cherry-pick of 822b277 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com