Skip to content

0.37.x: Use unclog for changelog control#129

Merged
lasarojc merged 8 commits intov0.37.xfrom
lasarojc/105-use-unclog.v0.37.0
Jan 18, 2023
Merged

0.37.x: Use unclog for changelog control#129
lasarojc merged 8 commits intov0.37.xfrom
lasarojc/105-use-unclog.v0.37.0

Conversation

@lasarojc
Copy link
Contributor

@lasarojc lasarojc commented Jan 16, 2023

Closes #105


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@lasarojc lasarojc linked an issue Jan 16, 2023 that may be closed by this pull request
@lasarojc lasarojc marked this pull request as ready for review January 16, 2023 20:09
@lasarojc lasarojc requested a review from a team as a code owner January 16, 2023 20:09
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lasarojc!

Please also include an epilogue file referencing the original changelog in the Tendermint Core repository - similar to the one you did for the cometbft-db repo.

@lasarojc
Copy link
Contributor Author

Pending updates to unclog for issue template and proper linking to issues, but these should not block reviews.

@lasarojc lasarojc changed the title Use unclog for changelog control 0.37.x: Use unclog for changelog control Jan 17, 2023
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy across the epilogue.md file changes from #130 and regenerate the CHANGELOG.md file on this branch before merging.

@lasarojc lasarojc merged commit 79fb683 into v0.37.x Jan 18, 2023
@lasarojc lasarojc deleted the lasarojc/105-use-unclog.v0.37.0 branch January 18, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to using unclog for CometBFT's changelog

2 participants