mempool: test FIFO ordering when disseminating txs#1169
Closed
Conversation
3 tasks
6 tasks
Collaborator
Author
|
The tests in this PR fail intermittently because they test for FIFO ordering, that is, they require that transactions arrive to peers in the order in which they were sent. FIFOness is really difficult to enforce, so we should consider whether it must be a requirement on the mempool and an assumption by the application. |
Contributor
|
FIFO is not really provided and we should check the documentation and code where this assumption might be made to remove/correct it. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was originally in #1043, and extracted from there.
The main addition here is the test
TestReactorPeerLagging. Also checking that transactions are in order inTestReactorTxSendersMultiNode.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments